Rollup of 11 pull requests #144860

samueltardieu · 2025-08-03T17:40:32Z

Successful merges:

Misc cleanups of generic_arg_infer related HIR logic #142678 (Misc cleanups of generic_arg_infer related HIR logic)
Additional tce tests #144650 (Additional tce tests)
Remove the omit_gdb_pretty_printer_section attribute #144738 (Remove the omit_gdb_pretty_printer_section attribute)
Multiple bounds checking elision failures #144790 (Multiple bounds checking elision failures)
compiletest: Preliminary cleanup of ProcRes printing/unwinding #144805 (compiletest: Preliminary cleanup of ProcRes printing/unwinding)
Interner arg to EarlyBinder does not affect auto traits #144808 (Interner arg to EarlyBinder does not affect auto traits)
Update E0562 to account for the new impl trait positions #144816 (Update E0562 to account for the new impl trait positions)
Return a struct with named fields from hash_owner_nodes #144822 (Return a struct with named fields from hash_owner_nodes)
Updated test links in compiler #144824 (Updated test links in compiler)
Use full flag name in strip command for Darwin #144829 (Use full flag name in strip command for Darwin)
Weekly cargo update #144843 (Weekly cargo update)

Failed merges:

Port #[coroutine] to the new attribute system #144794 (Port #[coroutine] to the new attribute system)

r? @ghost
@rustbot modify labels: rollup

Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.

Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`. This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup.

compiler & tools dependencies: Locking 14 packages to latest compatible versions Updating clap v4.5.41 -> v4.5.42 Updating clap_builder v4.5.41 -> v4.5.42 Updating jsonpath-rust v1.0.3 -> v1.0.4 Updating libredox v0.1.6 -> v0.1.9 Updating object v0.37.1 -> v0.37.2 Updating redox_syscall v0.5.16 -> v0.5.17 Updating redox_users v0.5.0 -> v0.5.2 Updating rustc-demangle v0.1.25 -> v0.1.26 Updating serde_json v1.0.141 -> v1.0.142 Updating wasm-encoder v0.235.0 -> v0.236.0 Updating wasmparser v0.235.0 -> v0.236.0 Updating wast v235.0.0 -> v236.0.0 Updating wat v1.235.0 -> v1.236.0 Updating windows-targets v0.53.2 -> v0.53.3 note: pass `--verbose` to see 36 unchanged dependencies behind latest library dependencies: Locking 3 packages to latest compatible versions Updating object v0.37.1 -> v0.37.2 Updating rustc-demangle v0.1.25 -> v0.1.26 Updating unwinding v0.2.7 -> v0.2.8 note: pass `--verbose` to see 2 unchanged dependencies behind latest rustbook dependencies: Locking 6 packages to latest compatible versions Updating cc v1.2.30 -> v1.2.31 Updating clap v4.5.41 -> v4.5.42 Updating clap_builder v4.5.41 -> v4.5.42 Updating redox_syscall v0.5.16 -> v0.5.17 Updating serde_json v1.0.141 -> v1.0.142 Updating windows-targets v0.53.2 -> v0.53.3

This method now returns a string instead of printing directly to (possibly-captured) stdout.

This reduces the amount of "hidden" printing in error-reporting code, which will be helpful when overhauling compiletest's error handling and output capture.

…or indexing into a function table as described by RFC 3407

Misc cleanups of `generic_arg_infer` related HIR logic r? ``@nnethercote``

…ffleLapkin Additional tce tests r? ``@oli-obk`` Adds known-bug tests for LLVM emissions regarding indirect operands for TCE. Also includes a test, `indexer.rs`, referring to function_table behavior described by the RFC. Depends on rust-lang#144232 Closes rust-lang#144293

…ter_section, r=jieyouxu Remove the omit_gdb_pretty_printer_section attribute Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.

…iler-errors Multiple bounds checking elision failures regression test for rust-lang#120433

compiletest: Preliminary cleanup of `ProcRes` printing/unwinding While experimenting with changes to how compiletest handles output capture, error reporting, and unwinding, I repeatedly ran in to difficulties with this core code for reporting test failures caused by a subprocess. There should be no change in compiletest output. r? jieyouxu

…ler-errors `Interner` arg to `EarlyBinder` does not affect auto traits Conceptually `EarlyBinder` does not contain an `Interner` so it shouldn't tell Rust it does via `PhantomData`. This is necessary for rust-analyzer as it stores `EarlyBinder`s in query results which require `Sync`, placing restrictions on our interner setup. r? compiler-errors

…leLapkin Update E0562 to account for the new impl trait positions fixes rust-lang#142683

…ler-errors Return a struct with named fields from `hash_owner_nodes` While looking through this code for other reasons, I noticed a nice opportunity to return a struct with named fields instead of a tuple. The first patch also introduces an early-return to flatten the rest of `hash_owner_nodes`. There are further changes that could potentially be made here (renaming things, `Option<Hashes>` instead of optional fields), but I'm not deeply familiar with this code so I didn't want to disturb the calling code too much.

Updated test links in compiler Updated test links since a bunch of tests got moved around from the top level recently r? compiler

Use full flag name in strip command for Darwin Darwin always uses `rust-objcopy` which supports long-form flags Solaris unchanged due to not having support for `--discard-all` and only `-x` fixes rust-lang#135038 r? ``@WaffleLapkin`` (since bot will ping you anyway, feel free to reroll)

Weekly `cargo update` Automation to keep dependencies in `Cargo.lock` current. r? dep-bumps The following is the output from `cargo update`: ```txt compiler & tools dependencies: Locking 14 packages to latest compatible versions Updating clap v4.5.41 -> v4.5.42 Updating clap_builder v4.5.41 -> v4.5.42 Updating jsonpath-rust v1.0.3 -> v1.0.4 Updating libredox v0.1.6 -> v0.1.9 Updating object v0.37.1 -> v0.37.2 Updating redox_syscall v0.5.16 -> v0.5.17 Updating redox_users v0.5.0 -> v0.5.2 Updating rustc-demangle v0.1.25 -> v0.1.26 Updating serde_json v1.0.141 -> v1.0.142 Updating wasm-encoder v0.235.0 -> v0.236.0 Updating wasmparser v0.235.0 -> v0.236.0 Updating wast v235.0.0 -> v236.0.0 Updating wat v1.235.0 -> v1.236.0 Updating windows-targets v0.53.2 -> v0.53.3 note: pass `--verbose` to see 36 unchanged dependencies behind latest library dependencies: Locking 3 packages to latest compatible versions Updating object v0.37.1 -> v0.37.2 Updating rustc-demangle v0.1.25 -> v0.1.26 Updating unwinding v0.2.7 -> v0.2.8 note: pass `--verbose` to see 2 unchanged dependencies behind latest rustbook dependencies: Locking 6 packages to latest compatible versions Updating cc v1.2.30 -> v1.2.31 Updating clap v4.5.41 -> v4.5.42 Updating clap_builder v4.5.41 -> v4.5.42 Updating redox_syscall v0.5.16 -> v0.5.17 Updating serde_json v1.0.141 -> v1.0.142 Updating windows-targets v0.53.2 -> v0.53.3 ```

samueltardieu · 2025-08-03T17:40:57Z

@bors r+ p=5 rollup=never

bors · 2025-08-03T17:41:00Z

📌 Commit ba2c7ba has been approved by samueltardieu

It is now in the queue for this repository.

Rollup of 11 pull requests Successful merges: - #142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - #144650 (Additional tce tests) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144790 (Multiple bounds checking elision failures) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) - #144843 (Weekly `cargo update`) Failed merges: - #144794 (Port `#[coroutine]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-08-03T18:47:25Z

⌛ Testing commit ba2c7ba with merge f9cd680...

rust-log-analyzer · 2025-08-03T19:43:23Z

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test [ui] tests/ui/explicit-tail-calls/ctfe-collatz-multi-rec.rs ... ok
test [ui] tests/ui/explicit-tail-calls/in-closure.rs ... ok
test [ui] tests/ui/explicit-tail-calls/ctfe-id-unlimited.rs#become ... ok
test [ui] tests/ui/explicit-tail-calls/indexer.rs ... ok
test [ui] tests/ui/explicit-tail-calls/recursion-etc-u64wrapper.rs ... FAILED
test [ui] tests/ui/explicit-tail-calls/return-lifetime-sub.rs ... ok
test [ui] tests/ui/explicit-tail-calls/recursion-etc.rs ... ok
test [ui] tests/ui/explicit-tail-calls/drop-order.rs ... ok
test [ui] tests/ui/explicit-tail-calls/return-mismatches.rs ... ok
test [ui] tests/ui/explicit-tail-calls/signature-mismatch.rs ... ok
---
test [ui] tests/ui/zero-sized/zero-sized-btreemap-insert.rs ... ok

failures:

---- [ui] tests/ui/explicit-tail-calls/recursion-etc-u64wrapper.rs stdout ----
Saved the actual stderr to `/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/explicit-tail-calls/recursion-etc-u64wrapper/recursion-etc-u64wrapper.stderr`
diff of stderr:

- error: internal compiler error: $COMPILER_DIR_REAL/rustc_codegen_ssa/src/mir/block.rs:LL:CC: arguments using PassMode::Indirect are currently not supported for tail calls
+ error: internal compiler error: /rustc-dev/f9cd680176393c261aa3e94d1604ff62035f9901/compiler/rustc_codegen_ssa/src/mir/block.rs:LL:CC: arguments using PassMode::Indirect are currently not supported for tail calls
2   --> $DIR/recursion-etc-u64wrapper.rs:23:16
3    |
4 LL |           become count(

Note: some mismatched output was normalized before being compared
##[error]- error: internal compiler error: /rustc-dev/f9cd680176393c261aa3e94d1604ff62035f9901/compiler/rustc_codegen_ssa/src/mir/block.rs:1059:17: arguments using PassMode::Indirect are currently not supported for tail calls
-   --> /checkout/tests/ui/explicit-tail-calls/recursion-etc-u64wrapper.rs:23:16
+ error: internal compiler error: /rustc-dev/f9cd680176393c261aa3e94d1604ff62035f9901/compiler/rustc_codegen_ssa/src/mir/block.rs:LL:CC: arguments using PassMode::Indirect are currently not supported for tail calls


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args explicit-tail-calls/recursion-etc-u64wrapper.rs`

error: 1 errors occurred comparing output.
status: exit status: 101
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/explicit-tail-calls/recursion-etc-u64wrapper.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=i586-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/explicit-tail-calls/recursion-etc-u64wrapper" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i586-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=i586-unknown-linux-gnu-gcc"
stdout: none
--- stderr -------------------------------
##[error]error: internal compiler error: /rustc-dev/f9cd680176393c261aa3e94d1604ff62035f9901/compiler/rustc_codegen_ssa/src/mir/block.rs:1059:17: arguments using PassMode::Indirect are currently not supported for tail calls
  --> /checkout/tests/ui/explicit-tail-calls/recursion-etc-u64wrapper.rs:23:16
   |
LL |           become count(
   |  ________________^
LL | |             U64Wrapper {
LL | |                 x: curr.x + 1,
LL | |                 arbitrary: curr.arbitrary,
LL | |             },
LL | |             top,
LL | |         )
   | |_________^

---
note: please make sure that you have updated to the latest nightly

note: rustc 1.91.0-nightly (f9cd68017 2025-08-03) running on x86_64-unknown-linux-gnu

note: compiler flags: -Z threads=1 -Z simulate-remapped-rust-src-base=/rustc/FAKE_PREFIX -Z translate-remapped-path-to-local-path=no -Z ignore-directory-in-diagnostics-source-blocks=/cargo -Z ignore-directory-in-diagnostics-source-blocks=/checkout/vendor -C codegen-units=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z write-long-types-to-disk=no -C strip=debuginfo -C prefer-dynamic -C rpath -C debuginfo=0 -C linker=i586-unknown-linux-gnu-gcc

query stack during panic:
end of query stack
error: aborting due to 1 previous error
------------------------------------------



failures:
    [ui] tests/ui/explicit-tail-calls/recursion-etc-u64wrapper.rs

test result: FAILED. 19160 passed; 1 failed; 373 ignored; 0 measured; 0 filtered out; finished in 652.16s

Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=i586-unknown-linux-gnu
Build completed unsuccessfully in 0:47:27

bors · 2025-08-03T19:44:13Z

💔 Test failed - checks-actions

jieyouxu · 2025-08-04T12:15:03Z

#144650
@bors r-

BoxyUwU and others added 28 commits June 17, 2025 15:02

Rename hir const arg walking functions

f4b7735

Don't double visit HirIds of inferred const/types

c9264a1

Link to dev-guide docs

2411fba

Reviews

fa5895e

Multiple bounds checking elision failures

19c6815

Update E0562 to account for the new impl trait positions

870b58f

Flatten hash_owner_nodes with an early-return

40f587a

Return a struct with named fields from hash_owner_nodes

d3e597a

update flags for consistency

f87e829

update links

8ca7986

Change ProcRes::print_info to format_info

2ddf0ca

This method now returns a string instead of printing directly to (possibly-captured) stdout.

Consolidate all ProcRes unwinds into one code path

d1d44d4

Change TestCx::error to error_prefix, which returns a string

1063b0f

This reduces the amount of "hidden" printing in error-reporting code, which will be helpful when overhauling compiletest's error handling and output capture.

explicit tail call tests with indirect operands in LLVM, small test f…

caa3cf1

…or indexing into a function table as described by RFC 3407

Rollup merge of rust-lang#142678 - BoxyUwU:gai_cleanup, r=nnethercote

f6dcf30

Misc cleanups of `generic_arg_infer` related HIR logic r? ``@nnethercote``

Rollup merge of rust-lang#144790 - lucarlig:pr-bounds-elision, r=comp…

930a31f

…iler-errors Multiple bounds checking elision failures regression test for rust-lang#120433

Rollup merge of rust-lang#144816 - Noratrieb:e0562-impl-trait, r=Waff…

1b08e83

…leLapkin Update E0562 to account for the new impl trait positions fixes rust-lang#142683

Rollup merge of rust-lang#144824 - Kivooeo:update-links, r=Noratrieb

dc961ce

Updated test links in compiler Updated test links since a bunch of tests got moved around from the top level recently r? compiler

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-compiletest Area: The compiletest test runner labels Aug 3, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 3, 2025

samueltardieu mentioned this pull request Aug 3, 2025

Additional tce tests #144650

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025

jieyouxu closed this Aug 4, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 4, 2025

samueltardieu deleted the rollup-3i49mfl branch August 4, 2025 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests #144860

Rollup of 11 pull requests #144860

Uh oh!

samueltardieu commented Aug 3, 2025 •

edited by rustbot

Loading

Uh oh!

samueltardieu commented Aug 3, 2025

Uh oh!

bors commented Aug 3, 2025

Uh oh!

bors commented Aug 3, 2025

Uh oh!

rust-log-analyzer commented Aug 3, 2025

Uh oh!

bors commented Aug 3, 2025

Uh oh!

jieyouxu commented Aug 4, 2025

Uh oh!

Uh oh!

Rollup of 11 pull requests #144860

Rollup of 11 pull requests #144860

Uh oh!

Conversation

samueltardieu commented Aug 3, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samueltardieu commented Aug 3, 2025

Uh oh!

bors commented Aug 3, 2025

Uh oh!

bors commented Aug 3, 2025

Uh oh!

rust-log-analyzer commented Aug 3, 2025

Uh oh!

bors commented Aug 3, 2025

Uh oh!

jieyouxu commented Aug 4, 2025

Uh oh!

Uh oh!

samueltardieu commented Aug 3, 2025 •

edited by rustbot

Loading